allow prereleases in nomad compatibility check#706
Merged
Conversation
RubelMozumder
approved these changes
Oct 1, 2025
Collaborator
RubelMozumder
left a comment
RubelMozumder
left a comment
There was a problem hiding this comment.
LGTM! But XRD is failing. I have not seen such an attribute unit_custom in XRD. Likely, this is coming from pynxtools modification.
Collaborator
Author
Oh yeah, this is because of #669. I changed the XRD test files already (see FAIRmat-NFDI/pynxtools-xrd@2c92768) so the tests would pass, but did want to bother you about it. We can just merge here and then the tests will work again in #669. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.